diff options
author | asami <asami@FreeBSD.org> | 1996-04-25 06:04:27 +0000 |
---|---|---|
committer | asami <asami@FreeBSD.org> | 1996-04-25 06:04:27 +0000 |
commit | 09153e86b5c58abbbe807cf1ecb9d89581bb9d5c (patch) | |
tree | 03054e6b97f2a0752d6722757072a39596120d77 | |
parent | c401fbe8f3c23f613e656100da5b71ca335bd9a8 (diff) | |
download | FreeBSD-src-09153e86b5c58abbbe807cf1ecb9d89581bb9d5c.zip FreeBSD-src-09153e86b5c58abbbe807cf1ecb9d89581bb9d5c.tar.gz |
Fix logic bug in pci bridge code. For a PCI-PCI bridge, secondary
should be <= than subordinate, not the other way around.
They are both true if the bridge is not cascaded (i.e., twin-channel
scsi/e-net adapters won't be affected by this bug), which is probably why
it was unnoticed until today.
-rw-r--r-- | sys/dev/pci/pci.c | 4 | ||||
-rw-r--r-- | sys/pci/pci.c | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/sys/dev/pci/pci.c b/sys/dev/pci/pci.c index 8033ebd..cc445d2 100644 --- a/sys/dev/pci/pci.c +++ b/sys/dev/pci/pci.c @@ -1,6 +1,6 @@ /************************************************************************** ** -** $Id: pci.c,v 1.47 1996/04/07 17:32:35 bde Exp $ +** $Id: pci.c,v 1.48 1996/04/14 20:14:36 se Exp $ ** ** General subroutines for the PCI bus. ** pci_configure () @@ -731,7 +731,7 @@ pci_bus_config (void) ** check for uninitialized bridge. */ if (!(primary < secondary - && subordinate <= secondary + && secondary <= subordinate && bus_no == primary)) { printf ("\tINCORRECTLY or NEVER CONFIGURED.\n"); diff --git a/sys/pci/pci.c b/sys/pci/pci.c index 8033ebd..cc445d2 100644 --- a/sys/pci/pci.c +++ b/sys/pci/pci.c @@ -1,6 +1,6 @@ /************************************************************************** ** -** $Id: pci.c,v 1.47 1996/04/07 17:32:35 bde Exp $ +** $Id: pci.c,v 1.48 1996/04/14 20:14:36 se Exp $ ** ** General subroutines for the PCI bus. ** pci_configure () @@ -731,7 +731,7 @@ pci_bus_config (void) ** check for uninitialized bridge. */ if (!(primary < secondary - && subordinate <= secondary + && secondary <= subordinate && bus_no == primary)) { printf ("\tINCORRECTLY or NEVER CONFIGURED.\n"); |