summaryrefslogtreecommitdiffstats
path: root/lang/ruby-devel/files/patch-tempfile.rb
blob: 4018f06739d98888a5df03cc4b3909ae81a43215 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
Index: lib/tempfile.rb
===================================================================
RCS file: /src/ruby/lib/tempfile.rb,v
retrieving revision 1.10
retrieving revision 1.12
diff -u -r1.10 -r1.12
--- lib/tempfile.rb	4 Jun 2002 07:34:19 -0000	1.10
+++ lib/tempfile.rb	18 Nov 2002 07:26:15 -0000	1.12
@@ -1,31 +1,43 @@
 #
-# $Id: tempfile.rb,v 1.10 2002/06/04 07:34:19 matz Exp $
+# $Id: tempfile.rb,v 1.12 2002/11/18 07:26:15 knu Exp $
 #
-# The class for temporary files.
-#  o creates a temporary file, which name is "basename.pid.n" with mode "w+".
-#  o Tempfile objects can be used like IO object.
-#  o with tempfile.close(true) created temporary files are removed.
-#  o created files are also removed on script termination.
-#  o with Tempfile#open, you can reopen the temporary file.
-#  o file mode of the temporary files are 0600.
+# This is a class for managing temporary files.
+#
+#  o Tempfile::new("basename") creates a temporary file whose name is
+#    "basename.pid.n" and opens with mode "w+".
+#  o A Tempfile object can be treated as an IO object.
+#  o The temporary directory is determined by ENV['TMPDIR'],
+#    ENV['TMP'], and ENV['TEMP'] in the order named, and if none of
+#    them is available, it is set to /tmp.
+#  o When $SAFE > 0, you should specify a directory via the second argument
+#    of Tempfile::new(), or it will end up finding an ENV value tainted and
+#    pick /tmp.  In case you don't have it, an exception will be raised.
+#  o Tempfile#close(true) gets the temporary file removed immediately.
+#  o Otherwise, the removal is delayed until the object is finalized.
+#  o With Tempfile#open, you can reopen the temporary file.
+#  o The file mode for the temporary files is 0600.
+#  o This library is (considered to be) thread safe.
 
 require 'delegate'
 
 class Tempfile < SimpleDelegator
   Max_try = 10
+  @@cleanlist = []
 
-  def Tempfile.callback(path, data)
+  def Tempfile.callback(data)
     pid = $$
     lambda{
       if pid == $$ 
+	path, tmpfile, cleanlist = *data
+
 	print "removing ", path, "..." if $DEBUG
-	data[0].close if data[0]
-	if File.exist?(path)
-	  File.unlink(path) 
-	end
-	if File.exist?(path + '.lock')
-	  Dir.rmdir(path + '.lock')
-	end
+
+	tmpfile.close if tmpfile
+
+	# keep this order for thread safeness
+	File.unlink(path) if File.exist?(path)
+	cleanlist.delete(path) if cleanlist
+
 	print "done\n" if $DEBUG
       end
     }
@@ -35,30 +47,44 @@
     if $SAFE > 0 and tmpdir.tainted?
       tmpdir = '/tmp'
     end
-    n = 0
-    while true
+
+    lock = nil
+    n = failure = 0
+    
+    begin
+      Thread.critical = true
+
       begin
 	tmpname = sprintf('%s/%s%d.%d', tmpdir, basename, $$, n)
 	lock = tmpname + '.lock'
-	unless File.exist?(tmpname) or File.exist?(lock)
-	  Dir.mkdir(lock)
-	  break
-	end
-      rescue
-	raise "cannot generate tempfile `%s'" % tmpname if n >= Max_try
-	#sleep(1)
-      end
-      n += 1
+	n += 1
+      end while @@cleanlist.include?(tmpname) or
+	File.exist?(lock) or File.exist?(tmpname)
+
+      Dir.mkdir(lock)
+    rescue
+      failure += 1
+      retry if failure < Max_try
+      raise "cannot generate tempfile `%s'" % tmpname
+    ensure
+      Thread.critical = false
     end
 
-    @protect = []
-    @clean_files = Tempfile.callback(tmpname, @protect)
-    ObjectSpace.define_finalizer(self, @clean_files)
+    @data = [tmpname]
+    @clean_proc = Tempfile.callback(@data)
+    ObjectSpace.define_finalizer(self, @clean_proc)
 
     @tmpfile = File.open(tmpname, File::RDWR|File::CREAT|File::EXCL, 0600)
-    @protect[0] = @tmpfile
     @tmpname = tmpname
+    @@cleanlist << @tmpname
+    @data[1] = @tmpfile
+    @data[2] = @@cleanlist
+
     super(@tmpfile)
+
+    # Now we have all the File/IO methods defined, you must not
+    # carelessly put bare puts(), etc. after this.
+
     Dir.rmdir(lock)
   end
 
@@ -69,15 +95,15 @@
   def open
     @tmpfile.close if @tmpfile
     @tmpfile = File.open(@tmpname, 'r+')
-    @protect[0] = @tmpfile
+    @data[1] = @tmpfile
     __setobj__(@tmpfile)
   end
 
   def close(real=false)
     @tmpfile.close if @tmpfile
-    @protect[0] = @tmpfile = nil
+    @data[1] = @tmpfile = nil
     if real
-      @clean_files.call
+      @clean_proc.call
       ObjectSpace.undefine_finalizer(self)
     end
   end
OpenPOWER on IntegriCloud